linux-kernel - Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2017 14:05:53 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Phil Elwell <phil@...pberrypi.org>
Cc:     Eric Anholt <eric@...olt.net>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Aishwarya Pant <aishpant@...il.com>,
        linux-rpi-kernel@...ts.infradead.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote:
> > This label name is out of date.  There is a later error path where
> > vc_vchi_audio_init() fails and we leak on that path.
> 
> Also agreed. I'll rework it.
> 

Actually I wasn't right.  That error path should probably stay how it
is, because we're re-using the vchi_instance.  We allocate it in the
first call then re-use it later.

This code is really subtle and ugly.

regards,
dan carpenter