linux-kernel - Re: [PATCH] Subject:drivers:staging:media:atomisp:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2017 14:09:37 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Harold Gomez <haroldgmz11@...il.com>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Subject:drivers:staging:media:atomisp:

Hi Harold,

Please use a better subject line.

On Thu, Aug 10, 2017 at 03:08:26PM +0530, Harold Gomez wrote:
> Fix Warning from checkpatch.pl 
> Block comments use * on subsequent lines
> 
> Signed-off-by: Harold Gomez <haroldgmz11@...il.com>
> ---
>  drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c
> index 9d6ce36..ac1aa96 100644
> --- a/drivers/staging/media/atomisp/i2c/ap1302.c
> +++ b/drivers/staging/media/atomisp/i2c/ap1302.c
> @@ -158,8 +158,9 @@ static struct ap1302_context_info context_info[] = {
>  };
>  
>  /* This array stores the description list for metadata.
> -   The metadata contains exposure settings and face
> -   detection results. */
> + * The metadata contains exposure settings and face
> + * detection results.
> + */

/*
 * Multi-line comments
 * look like this.
 */

>  static u16 ap1302_ss_list[] = {
>  	0xb01c, /* From 0x0186 with size 0x1C are exposure settings. */
>  	0x0186,
> -- 
> 2.1.4
> 

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk