linux-kernel - Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2017 20:23:17 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

Hi.


2017-08-10 20:11 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> 2017-08-10 19:37 GMT+09:00 Philipp Zabel <p.zabel@...gutronix.de>:
>> Hi Katsuhiro,
>>
>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>>> Add a reset line for analog signal amplifier core (ADAMV) on
>>> UniPhier LD11/LD20 SoCs.
>>>
>>> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
>>> ---
>>>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++
>>>  1 file changed, 15 insertions(+)
>>>
>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>>> index f60c137c17cb..cda4a78a58e2 100644
>>> --- a/drivers/reset/reset-uniphier.c
>>> +++ b/drivers/reset/reset-uniphier.c
>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
>>> >     UNIPHIER_RESET_END,
>>>  };
>>>
>>> +/* Analog signal amplifiers reset data */
>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
>>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>>> > +   UNIPHIER_RESET_END,
>>> +};


I take back my Acked-by.


The reset line index is independent from others
because this block is a separate instance.

Are you OK with starting from the reset ID 100?





-- 
Best Regards
Masahiro Yamada