linux-kernel - Re: [PATCH 04/12] [media] V4L2: platform: rcar_jpu: constify v4l2_m2m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALi4nhp_xQodYy9Y=Cma4NSJh5wwPKhSksfj+HAtJ4jnCMHrxg@mail.gmail.com>
Date:   Thu, 10 Aug 2017 16:38:49 +0300
From:   Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     bhumirks@...il.com, kernel-janitors@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/12] [media] V4L2: platform: rcar_jpu: constify
 v4l2_m2m_ops structures

On Sun, Aug 6, 2017 at 11:25 AM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> The v4l2_m2m_ops structures are only passed as the only
> argument to v4l2_m2m_init, which is declared as const.
> Thus the v4l2_m2m_ops structures themselves can be const.
>
> Done with the help of Coccinelle.
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct v4l2_m2m_ops i@p = { ... };
>
> @ok1@
> identifier r.i;
> position p;
> @@
> v4l2_m2m_init(&i@p)
>
> @bad@
> position p != {r.p,ok1.p};
> identifier r.i;
> struct v4l2_m2m_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct v4l2_m2m_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Ulyanov Mikhail <mikhail.ulyanov@...entembedded.com>