linux-kernel - Re: [PATCH v2] nvme: Fix nvme reset command timeout handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170810163250.GA14634@localhost.localdomain>
Date:   Thu, 10 Aug 2017 12:32:50 -0400
From:   Keith Busch <keith.busch@...el.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        Jens Axboe <axboe@...com>,
        Martin Peres <martin.peres@...el.com>
Subject: Re: [PATCH v2] nvme: Fix nvme reset command timeout handling

On Thu, Aug 10, 2017 at 11:23:31AM +0200, Johannes Thumshirn wrote:
> From: Keith Busch <keith.busch@...el.com>
> 
> We need to return an error if a timeout occurs on any NVMe command during
> initialization. Without this, the nvme reset work will be stuck. A timeout
> will have a negative error code, meaning we need to stop initializing
> the controller. All postitive returns mean the controller is still usable.
> 
> bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325
> 
> Signed-off-by: Keith Busch <keith.busch@...el.com>
> Cc: Martin Peres <martin.peres@...el.com>
> [jth consolidated cleanup path ]
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>

This looks great, thanks for fixing that up!

I noticed the HMB setting in pci.c can also potentially timeout. We can
deal with that later.