linux-kernel - Re: [PATCH 1/3] paravirt,xen: remove xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170810162920.a3jkgibz4iygi3g7@hirez.programming.kicks-ass.net>
Date:   Thu, 10 Aug 2017 18:29:20 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        x86@...nel.org, hpa@...or.com, mingo@...hat.com,
        tglx@...utronix.de, boris.ostrovsky@...cle.com,
        rusty@...tcorp.com.au, lguest@...ts.ozlabs.org
Subject: Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote:
> -ENTRY(xen_irq_enable_direct)
> -	FRAME_BEGIN
> -	/* Unmask events */
> -	movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask
> -
> -	/*
> -	 * Preempt here doesn't matter because that will deal with any
> -	 * pending interrupts.  The pending check may end up being run
> -	 * on the wrong CPU, but that doesn't hurt.
> -	 */
> -
> -	/* Test for pending */
> -	testb $0xff, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_pending
> -	jz 1f
> -
> -2:	call check_events
> -1:
> -ENDPATCH(xen_irq_enable_direct)
> -	FRAME_END
> -	ret
> -	ENDPROC(xen_irq_enable_direct)
> -	RELOC(xen_irq_enable_direct, 2b+1)

Oh my bad, part of that is still used.

arch/x86/xen/enlighten_pv.c:            pv_irq_ops.irq_enable = __PV_IS_CALLEE_SAVE(xen_irq_enable_direct);

It just needs cleanups for the ENDPATCH and such.