linux-kernel - [tip:perf/core] perf build: Clarify header version warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-c59796d53b1c96fd8a0a63119820fb81e06e4aa4@git.kernel.org>
Date:   Thu, 10 Aug 2017 09:27:49 -0700
From:   tip-bot for Ingo Molnar <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     jdesfossez@...icios.com, dsahern@...il.com, eranian@...gle.com,
        hpa@...or.com, milian.wolff@...b.com, sque@...omium.org,
        namhyung@...nel.org, adrian.hunter@...el.com, wangnan0@...wei.com,
        jolsa@...hat.com, gbastien@...satic.net, treeze.taeung@...il.com,
        acme@...hat.com, tglx@...utronix.de,
        francis.deslauriers@...icios.com, mathieu.desnoyers@...icios.com,
        linux-kernel@...r.kernel.org, davidcc@...gle.com,
        peterz@...radead.org, alexander.shishkin@...ux.intel.com,
        mliska@...e.cz, mingo@...nel.org, ak@...ux.intel.com,
        pjt@...gle.com
Subject: [tip:perf/core] perf build: Clarify header version warning message

Commit-ID:  c59796d53b1c96fd8a0a63119820fb81e06e4aa4
Gitweb:     http://git.kernel.org/tip/c59796d53b1c96fd8a0a63119820fb81e06e4aa4
Author:     Ingo Molnar <mingo@...nel.org>
AuthorDate: Sun, 30 Jul 2017 11:37:47 +0200
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Mon, 31 Jul 2017 10:27:56 -0300

perf build: Clarify header version warning message

Change this:

  Warning: arch/x86/include/asm/disabled-features.h differs from kernel
  Warning: arch/x86/include/asm/cpufeatures.h differs from kernel
  Warning: arch/powerpc/include/uapi/asm/kvm.h differs from kernel
  Warning: arch/s390/include/uapi/asm/kvm.h differs from kernel

  Warning: Kernel ABI header at 'tools/arch/x86/include/asm/disabled-features.h' differs from latest version at 'arch/x86/include/asm/disabled-features.h'
  Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
  Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/kvm.h' differs from latest version at 'arch/powerpc/include/uapi/asm/kvm.h'
  Warning: Kernel ABI header at 'tools/arch/s390/include/uapi/asm/kvm.h' differs from latest version at 'arch/s390/include/uapi/asm/kvm.h'

... to make it clearer what the warning is about, and to make it easier
to diff the two versions when syncing up the files.

Signed-off-by: Ingo Molnar <mingo@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: Andi Kleen <ak@...ux.intel.com>
Cc: David Ahern <dsahern@...il.com>
Cc: David Carrillo-Cisneros <davidcc@...gle.com>
Cc: Francis Deslauriers <francis.deslauriers@...icios.com>
Cc: Geneviève Bastien <gbastien@...satic.net>
Cc: Jiri Olsa <jolsa@...hat.com>
Cc: Julien Desfossez <jdesfossez@...icios.com>
Cc: Martin Liška <mliska@...e.cz>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Milian Wolff <milian.wolff@...b.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Paul Turner <pjt@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Simon Que <sque@...omium.org>
Cc: Stephane Eranian <eranian@...gle.com>
Cc: Taeung Song <treeze.taeung@...il.com>
Cc: Wang Nan <wangnan0@...wei.com>
Link: http://lkml.kernel.org/r/20170730093747.qogjn3lp7ntwcgwg@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/check-headers.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index 9b62958..d87bc6a 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -47,7 +47,7 @@ check () {
   cmd="diff $opts ../$file ../../$file > /dev/null"
 
   test -f ../../$file &&
-  eval $cmd || echo "Warning: $file differs from kernel" >&2
+  eval $cmd || echo "Warning: Kernel ABI header at 'tools/$file' differs from latest version at '$file'" >&2
 }