linux-kernel - Re: [PATCH] x86/platform/uv: make timeout_base_ns const and process_uv2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170810174621.GA130421@stormcage.americas.sgi.com>
Date:   Thu, 10 Aug 2017 12:46:22 -0500
From:   Andrew Banman <abanman@....com>
To:     Colin King <colin.king@...onical.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Andrew Banman <abanman@....com>,
        Mike Travis <mike.travis@....com>,
        Dimitri Sivanich <sivanich@....com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/platform/uv: make timeout_base_ns const and
 process_uv2_message static

Acked-by: Andrew Banman <abanman@....com>

On Thu, Aug 10, 2017 at 05:30:06PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Make array timeout_base_ns const. Also the function process_uv2_message
> is local to the source and do not need to be in global scope, so make it
> static.
> 
> Cleans up sparse warning:
> symbol 'process_uv2_message' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/platform/uv/tlb_uv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
> index 3e4bdb442fbc..f44c0bc95aa2 100644
> --- a/arch/x86/platform/uv/tlb_uv.c
> +++ b/arch/x86/platform/uv/tlb_uv.c
> @@ -26,7 +26,7 @@
>  static struct bau_operations ops __ro_after_init;
>  
>  /* timeouts in nanoseconds (indexed by UVH_AGING_PRESCALE_SEL urgency7 30:28) */
> -static int timeout_base_ns[] = {
> +static const int timeout_base_ns[] = {
>  		20,
>  		160,
>  		1280,
> @@ -1216,7 +1216,7 @@ static struct bau_pq_entry *find_another_by_swack(struct bau_pq_entry *msg,
>   * set a bit in the UVH_LB_BAU_INTD_SOFTWARE_ACKNOWLEDGE register.
>   * Such a message must be ignored.
>   */
> -void process_uv2_message(struct msg_desc *mdp, struct bau_control *bcp)
> +static void process_uv2_message(struct msg_desc *mdp, struct bau_control *bcp)
>  {
>  	unsigned long mmr_image;
>  	unsigned char swack_vec;
> -- 
> 2.11.0
>