linux-kernel - Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecc18d54-c1dd-6b8c-df7c-cc6d988a0c62@infradead.org>
Date:   Thu, 10 Aug 2017 11:24:04 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Thomas Meyer <thomas@...3r.de>, paul.burton@...tec.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have
 IOMEM

On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> This avoids the MODPOST error:
> ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
>  drivers/auxdisplay/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 9ae6681c90ad..9088c66e4c08 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -135,6 +135,7 @@ config CFAG12864B_RATE
>  
>  config IMG_ASCII_LCD
>  	tristate "Imagination Technologies ASCII LCD Display"
> +	depends on HAS_IOMEM
>  	default y if MIPS_MALTA || MIPS_SEAD3
>  	select SYSCON
>  	help
> 

I posted the same patch on 2017-JAN-01, so I agree with it.

https://lkml.org/lkml/2017/1/1/87

Acked-by: Randy Dunlap <rdunlap@...radead.org>

-- 
~Randy