linux-kernel - Re: [PATCH 16/29] scsi: esas2r: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46cd43a7-a246-ac67-ef54-97b19571908e@attotech.com>
Date:   Thu, 10 Aug 2017 14:59:22 -0400
From:   Bradley Grove <bgrove@...otech.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com, mdr@....com,
        hare@...e.com, aacraid@...ptec.com, matthew@....cx,
        fthain@...egraphics.com.au, schmitzmic@...il.com,
        kashyap.desai@...adcom.com, sumit.saxena@...adcom.com,
        gotom@...ian.or.jp, mrochs@...ux.vnet.ibm.com,
        QLogic-Storage-Upstream@...ium.com, jinpu.wang@...fitbricks.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/29] scsi: esas2r: constify pci_device_id.



Looks good.

Acked-by: Bradley Grove <bgrove@...otech.com>


On 07/30/2017 04:40 AM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>   drivers/scsi/esas2r/esas2r_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/esas2r/esas2r_main.c b/drivers/scsi/esas2r/esas2r_main.c
> index f2e9d8a..81f226b 100644
> --- a/drivers/scsi/esas2r/esas2r_main.c
> +++ b/drivers/scsi/esas2r/esas2r_main.c
> @@ -309,7 +309,7 @@ MODULE_PARM_DESC(interrupt_mode,
>   		 "Defines the interrupt mode to use.  0 for legacy"
>   		 ", 1 for MSI.  Default is MSI (1).");
>   
> -static struct pci_device_id
> +static const struct pci_device_id
>   	esas2r_pci_table[] = {
>   	{ ATTO_VENDOR_ID, 0x0049,	  ATTO_VENDOR_ID, 0x0049,
>   	  0,
> 




This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.