linux-kernel - Re: [PATCH 5/8] mfd: cros_ec: fail early if we cannot identify the EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170811040627.GC13907@decatoncale.mtv.corp.google.com>
Date:   Thu, 10 Aug 2017 21:06:27 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Thierry Escande <thierry.escande@...labora.com>
Cc:     Benson Leung <bleung@...omium.org>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        vpalatin@...omium.org, bleung@...gle.com
Subject: Re: [PATCH 5/8] mfd: cros_ec: fail early if we cannot identify the EC

Hi Thierry,

On Fri, Aug 11, 2017 at 12:16:47AM +0200, Thierry Escande wrote:
> From: Vincent Palatin <vpalatin@...omium.org>
> 
> If we cannot communicate with the EC chip to detect the protocol version
> and its features, it's very likely useless to continue. Else we will
> commit all kind of uninformed mistakes (using the wrong protocol, the
> wrong buffer size, mixing the EC with other chips).
> 
> Signed-off-by: Vincent Palatin <vpalatin@...omium.org>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>

Acked-by: Benson Leung <bleung@...omium.org>

> ---
>  drivers/mfd/cros_ec.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index b0ca5a4c..c5528ae 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
>  
>  	mutex_init(&ec_dev->lock);
>  
> -	cros_ec_query_all(ec_dev);
> +	err = cros_ec_query_all(ec_dev);
> +	if (err) {
> +		dev_err(dev, "Cannot identify the EC: error %d\n", err);
> +		return err;
> +	}
>  
>  	if (ec_dev->irq) {
>  		err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread,
> -- 
> 2.7.4
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)