linux-kernel - Re: [PATCH 4.4 01/58] parisc: Increase thread and stack size to 32kb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502415185.2047.29.camel@codethink.co.uk>
Date:   Fri, 11 Aug 2017 02:33:05 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Helge Deller <deller@....de>
Subject: Re: [PATCH 4.4 01/58] parisc: Increase thread and stack size to 32kb

On Wed, 2017-08-09 at 12:41 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Helge Deller <deller@....de>
> 
> commit 8f8201dfed91a43ac38c899c82f81eef3d36afd9 upstream.
> 
> Since kernel 4.11 the thread and irq stacks on parisc randomly overflow
> the default size of 16k. The reason why stack usage suddenly grew is yet
> unknown.

So we don't need this for 4.4.

Ben.

> Signed-off-by: Helge Deller <deller@....de>
> Signed-off-by: Helge Deller <deller@....de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  arch/parisc/include/asm/thread_info.h |    2 +-
>  arch/parisc/kernel/irq.c              |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/parisc/include/asm/thread_info.h
> +++ b/arch/parisc/include/asm/thread_info.h
> @@ -34,7 +34,7 @@ struct thread_info {
>  
>  /* thread information allocation */
>  
> -#define THREAD_SIZE_ORDER	2 /* PA-RISC requires at least 16k stack */
> +#define THREAD_SIZE_ORDER	3 /* PA-RISC requires at least 32k stack */
>  /* Be sure to hunt all references to this down when you change the size of
>   * the kernel stack */
>  #define THREAD_SIZE             (PAGE_SIZE << THREAD_SIZE_ORDER)
> --- a/arch/parisc/kernel/irq.c
> +++ b/arch/parisc/kernel/irq.c
> @@ -380,7 +380,7 @@ static inline int eirr_to_irq(unsigned l
>  /*
>   * IRQ STACK - used for irq handler
>   */
> -#define IRQ_STACK_SIZE      (4096 << 2) /* 16k irq stack size */
> +#define IRQ_STACK_SIZE      (4096 << 3) /* 32k irq stack size */
>  
>  union irq_stack_union {
>  	unsigned long stack[IRQ_STACK_SIZE/sizeof(unsigned long)];
> 
> 

-- 
Ben Hutchings
Software Developer, Codethink Ltd.