linux-kernel - Re: [PATCH v2] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <029a9c75-b8ca-1969-d846-fb49c4bc41bf@samsung.com>
Date:   Fri, 11 Aug 2017 15:00:22 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Anton Vasilyev <vasilyev@...ras.ru>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH v2] ASoC: samsung: i2s: Null pointer dereference on
 samsung_i2s_remove

On 08/11/2017 02:35 PM, Anton Vasilyev wrote:
> If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate
> sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove()
> permorms pri_dai->sec_dai dereference in any case.
   ^^^^^^^^
Still you have a typo here. ;)

> The patch adds sec_dai check on Null before derefence at
> samsung_i2s_remove().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Vasilyev<vasilyev@...ras.ru>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>