[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1502461385-27564-6-git-send-email-thierry.escande@collabora.com>
Date: Fri, 11 Aug 2017 16:23:02 +0200
From: Thierry Escande <thierry.escande@...labora.com>
To: Benson Leung <bleung@...omium.org>,
Lee Jones <lee.jones@...aro.org>,
Jonathan Cameron <jic23@...nel.org>
Cc: Joseph Lo <josephl@...dia.com>,
Gwendal Grignou <gwendal@...omium.org>,
Douglas Anderson <dianders@...omium.org>,
Daniel Hung-yu Wu <hywu@...gle.com>,
Vincent Palatin <vpalatin@...omium.org>,
Wei-Ning Huang <wnhuang@...gle.com>,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: [PATCH v2 5/8] mfd: cros_ec: fail early if we cannot identify the EC
From: Vincent Palatin <vpalatin@...omium.org>
If we cannot communicate with the EC chip to detect the protocol version
and its features, it's very likely useless to continue. Else we will
commit all kind of uninformed mistakes (using the wrong protocol, the
wrong buffer size, mixing the EC with other chips).
Signed-off-by: Vincent Palatin <vpalatin@...omium.org>
Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
Acked-by: Benson Leung <bleung@...omium.org>
---
drivers/mfd/cros_ec.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index b0ca5a4c..c5528ae 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
mutex_init(&ec_dev->lock);
- cros_ec_query_all(ec_dev);
+ err = cros_ec_query_all(ec_dev);
+ if (err) {
+ dev_err(dev, "Cannot identify the EC: error %d\n", err);
+ return err;
+ }
if (ec_dev->irq) {
err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread,
--
2.7.4
Powered by blists - more mailing lists