linux-kernel - Re: [PATCH][drm-next] drm/i915: make structure intel_sprite_plane_funcs static

Open Source and information security mailing list archives

Message-ID: <20170811160632.n5kmtyom4xwsk6xx@phenom.ffwll.local>
Date:   Fri, 11 Aug 2017 18:06:32 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Colin King <colin.king@...onical.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][drm-next] drm/i915: make structure
 intel_sprite_plane_funcs static

On Fri, Aug 11, 2017 at 02:49:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The structure intel_sprite_plane_funcs is local to the source
> and does not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'intel_sprite_plane_funcs' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index e11f8782c9eb..524933b01483 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1184,7 +1184,7 @@ static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
>  	unreachable();
>  }
>  
> -const struct drm_plane_funcs intel_sprite_plane_funcs = {
> +static const struct drm_plane_funcs intel_sprite_plane_funcs = {
>          .update_plane = drm_atomic_helper_update_plane,
>          .disable_plane = drm_atomic_helper_disable_plane,
>          .destroy = intel_plane_destroy,
> -- 
> 2.11.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives