linux-kernel - Re: [PATCH] selftests: memfd: Align STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb15ec12-9502-8f55-0ec1-68054330bb59@kernel.org>
Date:   Fri, 11 Aug 2017 10:10:34 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Sumit Semwal <sumit.semwal@...aro.org>,
        Orson Zhai <orson.zhai@...aro.org>
Cc:     "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        chunyan.zhang@...eadtrum.com, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system

On 08/11/2017 09:55 AM, Sumit Semwal wrote:
> Hello Orson,
> 
> Thanks for the patch.
> 
> On 10 August 2017 at 16:34, Orson Zhai <orson.zhai@...aro.org> wrote:
>> The stack size should be 16 bytes aligned in arm64 system. The similar
>> patch has been merged already.
>>
>>> <commit id: 1f78dda2cf5e4eeb00aee2a01c9515e2e704b4c0>
>>> selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
>>>
>>>    There is a mandate of 16-byte aligned stack on AArch64 [1], so the
>>>    STACK_SIZE here should also be 16-byte aligned, otherwise we would
>>>    get an error when calling clone().
>>>
>>>    [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>>>
>>>    Signed-off-by: Chunyan Zhang <zhang.chunyan@...aro.org>
>>>    Acked-by: Arnd Bergmann <arnd@...db.de>
>>>    Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>>
>> Signed-off-by: Orson Zhai <orson.zhai@...aro.org>
> Please feel free to add my
> Reviewed-by: Sumit Semwal <sumit.semwal@...aro.org>

Thanks for the patch and review.
Applied to linux-kselftest next for 4.14-rc1

thanks,
-- Shuah