linux-kernel - Re: [PATCH V2 2/2] pinctrl: qcom: spmi-gpio: Add dtest route for digital input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2017 09:27:22 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     fenglinw@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        collinsd@...eaurora.org, aghayal@...eaurora.org,
        wruan@...eaurora.org, kgunda@...eaurora.org
Subject: Re: [PATCH V2 2/2] pinctrl: qcom: spmi-gpio: Add dtest route for
 digital input

On Tue 18 Jul 23:30 PDT 2017, fenglinw@...eaurora.org wrote:
[..]
> @@ -528,6 +547,20 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
>  	if (ret < 0)
>  		return ret;
>  
> +	if (pad->dtest_buffer == 0) {
> +		val = 0;
> +	} else {
> +		if (pad->lv_mv_type) {
> +			val = pad->dtest_buffer - 1;
> +			val |= PMIC_GPIO_LV_MV_DIG_IN_DTEST_EN;
> +		} else {
> +			val = 1 << (pad->dtest_buffer - 1);

val = BIT(pad->dtest_buffer - 1);


Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn