linux-kernel - Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

Open Source and information security mailing list archives

Message-ID: <1502421075.19230.23.camel@mtkswgap22>
Date:   Fri, 11 Aug 2017 11:11:15 +0800
From:   Sean Wang <sean.wang@...iatek.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <mark.rutland@....com>, <jamesjj.liao@...iatek.com>,
        <devicetree@...r.kernel.org>, <chenglin.xu@...iatek.com>,
        <lgirdwood@...il.com>, <henryc.chen@...iatek.com>,
        <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>,
        <linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>,
        <chen.zhong@...iatek.com>
Subject: Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

On Tue, 2017-07-18 at 14:31 +0100, Mark Brown wrote:
> On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@...iatek.com wrote:
> 
> > +	if (!info->modeset_mask) {
> > +		dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n",
> > +			info->desc.name);
> > +		return -EINVAL;
> > +	}
> 
> This is mostly fine but the mode operations all have this code - if the
> regulator doesn't have modesetting facilities it just shouldn't have
> the ops so the core can handle things in a standard fashion.  It'd mean
> defining a separate set of operations for those regulators but that's
> fine.

Hi, Mark

it is really bad for those calls with certain regulator always returning
-EINVAL, that doesn't make sense.

we'll follow your suggestion and add them into the next version.

thanks for your help!

	Sean

> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives