linux-kernel - Re: [PATCH] ASoC: hdmi-codec: Use different name for playback streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170811165908.GA67191@google.com>
Date:   Fri, 11 Aug 2017 09:59:09 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, dianders@...omium.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: hdmi-codec: Use different name for playback streams

Hi Jeffy,

You need to be more careful about the addressee's of your patches. No
one on To/CC is a maintainer or a sufficiently-targeted mailing list. I
doubt any of the maintainers will read your patch. (I've added
alsa-devel for you, but given my understanding of at least Mark's
patchwork workflow -- and of general patch etiquette -- it's important
the patch is actually sent there in the first place.)

Probably worth resending.

Brian

On Fri, Aug 11, 2017 at 04:29:33PM +0800, Jeffy Chen wrote:
> Currently the hdmi i2s playback stream and hdmi spdif playback stream
> are using the same name. So when they are enabled at the same time,
> kernel will print this warning:
> 
> [    2.201835] hdmi-audio-codec hdmi-audio-codec.1.auto: ASoC: Failed to
> create Playback debugfs file
> 
> Assign different names to them to avoid that.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> ---
> 
>  sound/soc/codecs/hdmi-codec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
> index 509ab51..a2af440 100644
> --- a/sound/soc/codecs/hdmi-codec.c
> +++ b/sound/soc/codecs/hdmi-codec.c
> @@ -696,7 +696,7 @@ static struct snd_soc_dai_driver hdmi_i2s_dai = {
>  	.name = "i2s-hifi",
>  	.id = DAI_ID_I2S,
>  	.playback = {
> -		.stream_name = "Playback",
> +		.stream_name = "I2S Playback",
>  		.channels_min = 2,
>  		.channels_max = 8,
>  		.rates = HDMI_RATES,
> @@ -711,7 +711,7 @@ static const struct snd_soc_dai_driver hdmi_spdif_dai = {
>  	.name = "spdif-hifi",
>  	.id = DAI_ID_SPDIF,
>  	.playback = {
> -		.stream_name = "Playback",
> +		.stream_name = "SPDIF Playback",
>  		.channels_min = 2,
>  		.channels_max = 2,
>  		.rates = HDMI_RATES,
> -- 
> 2.1.4
> 
>