linux-kernel - Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bmnlq5w9.fsf@belgarion.home>
Date:   Fri, 11 Aug 2017 21:08:22 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec

Lee Jones <lee.jones@...aro.org> writes:

> On Sun, 06 Aug 2017, Robert Jarzmik wrote:

Hi Lee,

I basically agree with all your comments, so I will only answer to your
questions.
>> +#include <linux/module.h>
>
> Why separate this?
No point, for v6.
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>
> Can you use the short version?
Yeah, sure.

>> +#ifndef __LINUX_MFD_WM97XX_H
>> +#define __LINUX_MFD_WM97XX_H
>> +
>> +struct regmap;
>> +struct wm97xx_batt_pdata;
>> +struct snd_ac97;
>
> What are you using these for?
There are for the structure just below, which doesn't need the implementation
details of these structures, but does need the definition to properly compile.

>> +struct wm97xx_platform_data {
>> +	struct snd_ac97 *ac97;
>> +	struct regmap *regmap;
>> +	struct wm97xx_batt_pdata *batt_pdata;
>> +};
This is the structure "just below" I'm speaking of.

Thanks for the review.

-- 
Robert