linux-kernel - Re: [PATCH 6/7] iio: srf08: add buffered to device mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170812130208.2ed84b76@archlinux>
Date:   Sat, 12 Aug 2017 13:02:08 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, wsa@...-dreams.de, robh+dt@...nel.org,
        mark.rutland@....com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] iio: srf08: add buffered to device mode

On Thu, 3 Aug 2017 01:26:09 +0200
Andreas Klinger <ak@...klinger.de> wrote:

> Add INDIO_BUFFER_TRIGGERED and INDIO_BUFFER_SOFTWARE to device mode
> 
> Signed-off-by: Andreas Klinger <ak@...klinger.de>
> ---
>  drivers/iio/proximity/srf08.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index a63c272c3b22..ea238ab1066c 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -437,7 +437,9 @@ static int srf08_probe(struct i2c_client *client,
>  
>  	indio_dev->name = id->name;
>  	indio_dev->dev.parent = &client->dev;
> -	indio_dev->modes = INDIO_DIRECT_MODE;
> +	indio_dev->modes = INDIO_DIRECT_MODE
> +				| INDIO_BUFFER_TRIGGERED
Huh.?  Firstly I think only one of these is relevant and secondly
should be merged back into the original patch that added the support.

Also the triggered_buffer setup already set it for you...

So all in all, drop this patch.

Jonathan
> +				| INDIO_BUFFER_SOFTWARE;
>  
>  	/* srf02 is not using sensitivity nor max_range */
>  	if (id->driver_data == SRF02)