linux-kernel - Re: [PATCH] staging: iio: adc: fix error return code in ad7606_par

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 12 Aug 2017 13:08:54 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: adc: fix error return code in
 ad7606_par_probe()

On Wed, 9 Aug 2017 10:38:56 -0500
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> platform_get_irq() returns an error code, but the ad7606_par driver
> ignores it and always returns -ENODEV. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
> 
> Print and propagate the return value of platform_get_irq on failure.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Applied to the togreg branch of iio.git.

As we have no reports of anyone actually finding this a problem I'm
taking it the slow way and it will wait for the next merge window.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/adc/ad7606_par.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c
> index cd6c410c..3eb6f8f 100644
> --- a/drivers/staging/iio/adc/ad7606_par.c
> +++ b/drivers/staging/iio/adc/ad7606_par.c
> @@ -57,8 +57,8 @@ static int ad7606_par_probe(struct platform_device *pdev)
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -		dev_err(&pdev->dev, "no irq\n");
> -		return -ENODEV;
> +		dev_err(&pdev->dev, "no irq: %d\n", irq);
> +		return irq;
>  	}
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);