linux-kernel - Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170812232248.GA20719@kroah.com>
Date:   Sat, 12 Aug 2017 16:22:48 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Michael Thayer <michael.thayer@...cle.com>,
        "Knut St . Osmundsen" <knut.osmundsen@...cle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Larry Finger <Larry.Finger@...inger.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>
Subject: Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest
 integration

On Sat, Aug 12, 2017 at 11:56:22PM +0200, Hans de Goede wrote:
> > 'u32' is not an approprioate type for a kernel header, use '__u32'
> > instead.
> 
> Huh I thought that u32 was preferred, but I guess that it is not allowed
> in uapi headers due to potential conflicts and it should be __u32 in uapi
> headers ?

The __ version should always be used in structures/variables that cross
the user/kernel boundry as they are guaranteed to be correct that way.
That is a requirement.

Use the "normal" non __ versions for in-kernel only variables.

hope this helps,

greg k-h