linux-kernel - Re: [PATCH v3] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170812071051.vslbtrgn732v7hvr@kozik-lap>
Date:   Sat, 12 Aug 2017 09:10:51 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Anton Vasilyev <vasilyev@...ras.ru>
Cc:     Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH v3] ASoC: samsung: i2s: Null pointer dereference on
 samsung_i2s_remove

On Fri, Aug 11, 2017 at 04:06:23PM +0300, Anton Vasilyev wrote:
> If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate
> sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove()
> performs pri_dai->sec_dai dereference in any case.
> 
> The patch adds sec_dai check on Null before derefence at
> samsung_i2s_remove().

No, I think this patch does not any check.

Best regards,
Krzysztof


> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Vasilyev <vasilyev@...ras.ru>
> ---
> v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove
> as Sylwester Nawrocki suggest.
> ---
> v3: Fix typo in the comment
> ---
>  sound/soc/samsung/i2s.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
> index af3ba4d..6f896e3 100644
> --- a/sound/soc/samsung/i2s.c
> +++ b/sound/soc/samsung/i2s.c
> @@ -1376,13 +1376,9 @@ static int samsung_i2s_probe(struct platform_device *pdev)
>  
>  static int samsung_i2s_remove(struct platform_device *pdev)
>  {
> -	struct i2s_dai *pri_dai, *sec_dai;
> +	struct i2s_dai *pri_dai;
>  
>  	pri_dai = dev_get_drvdata(&pdev->dev);
> -	sec_dai = pri_dai->sec_dai;
> -
> -	pri_dai->sec_dai = NULL;
> -	sec_dai->pri_dai = NULL;
>  
>  	pm_runtime_get_sync(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
> -- 
> 2.7.4
>