linux-kernel - Re: [PATCH 0/6] constify pci_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170812074451.GA3589@infradead.org>
Date:   Sat, 12 Aug 2017 00:44:51 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     linux-scsi@...r.kernel.org, bhumirks@...il.com,
        kernel-janitors@...r.kernel.org, MPT-FusionLinux.pdl@...adcom.com,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 0/6] constify pci_error_handlers structures

On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote:
> These pci_error_handlers structures are only stored in the err_handler
> field of a pci_driver structure, and this field is declared as const.  Thus
> the pci_error_handlers structures can be const too.
> 
> Done with the help of Coccinelle.

If you're doing a scripted conversion of the pci_error_handlers
structured I'd much rather see that structure killed off and folded
into the pci_driver one.