linux-kernel - Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Aug 2017 14:13:01 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Andy Yan <andy.yan@...k-chips.com>
Cc:     robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108

Hi Andy,

Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108 soc
> 
> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
> 

> +	adc: adc@...8c000 {
> +		compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
> +		reg = <0x1038c000 0x100>;
> +		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +		#io-channel-cells = <1>;
> +		io-channel-ranges;

What do you need the io-channel-ranges for?
I.e. according to the documenation it is meant for when the adc is also
a "bus node" and has children that should inherit channels from it.

In all saradc uses so far we only have separate nodes referencing the
adc controller (like adc-keys etc), so this does not look like it is needed?

Heiko