linux-kernel - Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Aug 2017 08:23:13 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API

On Sun, Aug 13, 2017 at 7:15 AM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Sun, 2017-08-06 at 08:43 -0700, Andy Lutomirski wrote:
>> On Fri, Aug 4, 2017 at 8:27 AM, Andy Shevchenko
>> <andy.shevchenko@...il.com> wrote:
>> > On Fri, Aug 4, 2017 at 6:01 PM, Andy Lutomirski <luto@...nel.org>
>> > wrote:
>> > > > On Aug 2, 2017, at 9:28 AM, Andy Shevchenko <andriy.shevchenko@l
>> > > > inux.intel.com> wrote:
>
>> > > NAK.  guid_block is a firmware interface, so opaque kernel types
>> > > don't
>> > > belong in it.
>> >
>> > I f we leave this, what do you think about everything else?
>>
>> Assuming it works, it's fine with me.  I'd be happy to test.
>
> Just sent v2.
>
>> Keep in mind that this beast is a *little-endian* GUID abomination,
>> and I don't see generic conversion helpers.  Something might need to
>> be added.
>
> Do you mean something like char16_to_guid() / char16_to_uuid() ?

No, I mean something like uuid_le_to_guid().  There's an existing
helper uuid_le_to_bin() which, for all that the implementation and
signature is ridiculous, does the right thing.