linux-kernel - Re: [PATCH v2] platform/x86: wmi: Switch to use new generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrXMTFuEYZEZK8P90Z6oUwgxQzHeS3tQjKtyS5=VRpwT=w@mail.gmail.com>
Date:   Sun, 13 Aug 2017 08:36:48 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] platform/x86: wmi: Switch to use new generic UUID API

On Sun, Aug 13, 2017 at 7:13 AM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
>
> While here, update Copyright to reflect this change along with previous
> one for the topic.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

>
> -               if (memcmp(block->gblock.guid, &guid_input, 16) == 0) {
> +               if (guid_equal((guid_t *)&block->gblock.guid, &guid_input)) {

As discussed in the other email, NAK.

This line should read:

if (uuid_le_equal(...))

or

if (uuid_le_equal_uuid(...))

or similar.  Barring that, I think memcmp() is far better than the
obviously-wrong-but-actually-secretly-correct guid_equal().

--Andy