linux-kernel - RE: [PATCH 3/6] scsi: aacraid: constify pci_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423FD6710FB8FB4F8728F93591889F9A5B3E16C1@avsrvexchmbx2.microsemi.net>
Date:   Sun, 13 Aug 2017 02:32:23 +0000
From:   Dave Carroll <david.carroll@...rosemi.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>
CC:     "bhumirks@...il.com" <bhumirks@...il.com>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/6] scsi: aacraid: constify pci_error_handlers
 structures

> 
> These pci_error_handlers structures are only stored in the err_handler field of a
> pci_driver structure, and this field is declared as const.  Thus the
> pci_error_handlers structures can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/scsi/aacraid/linit.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index
> a8dedc3..2b978d8 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -2070,7 +2070,7 @@ static void aac_pci_resume(struct pci_dev *pdev)
>         dev_err(&pdev->dev, "aacraid: PCI error - resume\n");  }
> 
> -static struct pci_error_handlers aac_pci_err_handler = {
> +static const struct pci_error_handlers aac_pci_err_handler = {
>         .error_detected         = aac_pci_error_detected,
>         .mmio_enabled           = aac_pci_mmio_enabled,
>         .slot_reset             = aac_pci_slot_reset,

Acked-by: Dave Carroll <david.carroll@...rosemi.com>