linux-kernel - Re: mtd: nand: use dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170813095648.4a2a2764@bbrezillon>
Date:   Sun, 13 Aug 2017 09:56:48 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Pan Bian <bianpan2016@....com>
Cc:     Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: mtd: nand: use dma_mapping_error to check map errors

Le Tue,  8 Aug 2017 22:35:42 +0800,
Pan Bian <bianpan2016@....com> a écrit :

> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function flctl_dma_fifo0_transfer(), its
> return value is checked against NULL, which could result in failures.

Applied, thanks.

Boris

> 
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/mtd/nand/sh_flctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
> index 891ac7b..2404d66 100644
> --- a/drivers/mtd/nand/sh_flctl.c
> +++ b/drivers/mtd/nand/sh_flctl.c
> @@ -411,7 +411,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
>  
>  	dma_addr = dma_map_single(chan->device->dev, buf, len, dir);
>  
> -	if (dma_addr)
> +	if (!dma_mapping_error(chan->device->dev, dma_addr))
>  		desc = dmaengine_prep_slave_single(chan, dma_addr, len,
>  			tr_dir, DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
>