linux-kernel - Re: [PATCH] ACPI / PMIC: constify platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 13 Aug 2017 13:47:34 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, rjw@...ysocki.net,
        lenb@...nel.org, andriy.shevchenko@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / PMIC: constify platform_device_id

Hi,

On 13-08-17 13:23, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Good catch:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
> index 85636d7..813b829 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtwc.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
> @@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
>   			&intel_cht_wc_pmic_opregion_data);
>   }
>   
> -static struct platform_device_id cht_wc_opregion_id_table[] = {
> +static const struct platform_device_id cht_wc_opregion_id_table[] = {
>   	{ .name = "cht_wcove_region" },
>   	{},
>   };
>