linux-kernel - Re: [PATCH] thermal: intel_pch_thermal: Fix enable check on Broadwell-DE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1502753944.10633.1.camel@intel.com>
Date:   Mon, 14 Aug 2017 23:39:06 +0000
From:   "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "eswierk@...portsystems.com" <eswierk@...portsystems.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] thermal: intel_pch_thermal: Fix enable check on
 Broadwell-DE

On Wed, 2017-07-19 at 17:44 -0700, Ed Swierk wrote:
> Using the TSDSS flag to determine whether the thermal sensor is
> enabled is problematic. Broadwell-DE (Xeon D-1500) does not support
> dynamic shutdown and the TSDSS flag always reads 0 (contrary to the
> current datasheet). Even on hardware supporting dynamic shutdown, the
> driver does nothing to configure it, and the dynamic shutdown state
> should not prevent the driver from loading. The ETS flag itself
> indicates whether the thermal sensor is enabled, so use it instead of
> the TSDSS flag on all hardware platforms.
> 
> Signed-off-by: Ed Swierk <eswierk@...portsystems.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/thermal/intel_pch_thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/intel_pch_thermal.c
> b/drivers/thermal/intel_pch_thermal.c
> index 2b49e8d..9889c90 100644
> --- a/drivers/thermal/intel_pch_thermal.c
> +++ b/drivers/thermal/intel_pch_thermal.c
> @@ -125,7 +125,7 @@ static int pch_wpt_init(struct pch_thermal_device
> *ptd, int *nr_trips)
>  	*nr_trips = 0;
>  
>  	/* Check if BIOS has already enabled thermal sensor */
> -	if (WPT_TSS_TSDSS & readb(ptd->hw_base + WPT_TSS)) {
> +	if (WPT_TSEL_ETS & readb(ptd->hw_base + WPT_TSEL)) {
>  		ptd->bios_enabled = true;
>  		goto read_trips;
>  	}
> @@ -141,7 +141,7 @@ static int pch_wpt_init(struct pch_thermal_device
> *ptd, int *nr_trips)
>  	}
>  
>  	writeb(tsel|WPT_TSEL_ETS, ptd->hw_base + WPT_TSEL);
> -	if (!(WPT_TSS_TSDSS & readb(ptd->hw_base + WPT_TSS))) {
> +	if (!(WPT_TSEL_ETS & readb(ptd->hw_base + WPT_TSEL))) {
>  		dev_err(&ptd->pdev->dev, "Sensor can't be
> enabled\n");
>  		return -ENODEV;
>  	}