linux-kernel - [RFC] block: deprecate choosing elevator via boot param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 11:27:12 +0200
From:   Oleksandr Natalenko <oleksandr@...hat.com>
To:     linux-block@...r.kernel.org
Cc:     axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: [RFC] block: deprecate choosing elevator via boot param

Setting I/O scheduler via kernel command line is not flexible enough
anymore. Different schedulers might be desirable for different types
of devices (SSDs and HDDs, for instance). Moreover, setting elevator
while using blk-mq framework does not work in this way already.

This commit enables warning if user specifies "elevator" boot param.
Removing this option at all might be considered in some future.

Signed-off-by: Oleksandr Natalenko <oleksandr@...hat.com>
---
 block/elevator.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/elevator.c b/block/elevator.c
index 4bb2f0c93fa6..9ade7e12e417 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -130,6 +130,9 @@ static int __init elevator_setup(char *str)
 	 * Be backwards-compatible with previous kernels, so users
 	 * won't get the wrong elevator.
 	 */
+	printk(KERN_WARNING
+		"Setting I/O scheduler via kernel command line " \
+		"is deprecated. Use udev rule instead.");
 	strncpy(chosen_elevator, str, sizeof(chosen_elevator) - 1);
 	return 1;
 }
-- 
2.14.1