linux-kernel - Re: [PATCH] net/bluetooth: make bluetooth socket can be created in net namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6EC96C1E-CE98-4CF1-B1B2-1CEC9DBC36EA@holtmann.org>
Date:   Mon, 14 Aug 2017 11:30:02 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     fupan.li@...driver.com
Cc:     "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/bluetooth: make bluetooth socket can be created in
 net namespace

Hi Fupan,

> By now kernel only supported creating bluetooth socket in init_net
> net namespace, which made bluetooth device cannot be accessed in
> containers, this patch made bluetooth socket can be created in
> net namespaces to fix this issue.
> 
> Signed-off-by: Fupan Li <fupan.li@...driver.com>
> ---
> net/bluetooth/af_bluetooth.c | 2 +-
> net/bluetooth/bnep/sock.c    | 4 ++--
> net/bluetooth/cmtp/sock.c    | 4 ++--
> net/bluetooth/hci_sock.c     | 4 ++--
> net/bluetooth/hidp/sock.c    | 4 ++--
> net/bluetooth/l2cap_sock.c   | 4 ++--
> net/bluetooth/rfcomm/core.c  | 2 +-
> net/bluetooth/rfcomm/sock.c  | 4 ++--
> net/bluetooth/sco.c          | 4 ++--
> 9 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
> index 91e3ba280706..eec5ac17faee 100644
> --- a/net/bluetooth/af_bluetooth.c
> +++ b/net/bluetooth/af_bluetooth.c
> @@ -113,7 +113,7 @@ static int bt_sock_create(struct net *net, struct socket *sock, int proto,
> {
> 	int err;
> 
> -	if (net != &init_net)
> +	if (!net_eq(net, current->nsproxy->net_ns)) 
> 		return -EAFNOSUPPORT;

before I apply such a patch, what is the actual change here. What impact does this have? Are things like Bluetooth mgmt sockets still operating correctly after this? We have no support for move a Bluetooth controller into a container. The Bluetooth hardware is global.

Regards

Marcel