linux-kernel - Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1502718347.2586.16.camel@synopsys.com>
Date:   Mon, 14 Aug 2017 13:45:47 +0000
From:   Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
To:     "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alex.g@...ptrum.com" <alex.g@...ptrum.com>,
        "Eugeniy.Paltsev@...opsys.com" <Eugeniy.Paltsev@...opsys.com>,
        "s.trumtrar@...gutronix.de" <s.trumtrar@...gutronix.de>,
        "andre.przywara@....com" <andre.przywara@....com>,
        "wens@...e.org" <wens@...e.org>,
        "baoyou.xie@...aro.org" <baoyou.xie@...aro.org>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "maxime.ripard@...e-electrons.com" <maxime.ripard@...e-electrons.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32,
 sunxi, and zx2967

Hi Philipp,

On Fri, 2017-08-11 at 18:37 +0200, Philipp Zabel wrote:
> > > +struct reset_simple_devdata {
> > > > > +	bool inverted;
> > > 
> > > +};
> > > +
> > > +static const struct reset_simple_devdata reset_simple_inverted =
> > > {
> > > +	.inverted = true,
> > 
> > Hmm. I think it would be useful for new devices if there were have
> > a way 
> > to specify this in devicetree.
> 
> This is a separate issue, and it should be discussed including the
> device tree list.
> 
> It could be as simple as a boolean "active-low;" property. But then
> absence of that property would not mean active-high for existing
> active-low drivers, which is confusing.
> 
> It could also reuse the flags already defined in
> dt-bindings/reset/ti-syscon.h and have some kind of
>     reset-flags = <ASSERT_SET | DEASSERT_CLEAR | STATUS_SET>;
> property.
> 
> Suggestions welcome.
> 

Imho,

reset-type = <ACTIVE_LOW | ACTIVE_HIGH>;

looks good.
-- 
 Eugeniy Paltsev