linux-kernel - Re: [PATCH] drm: udl: constify usb_device_id

Open Source and information security mailing list archives

Message-ID: <20170814141237.nkxzuligzp35ovyt@phenom.ffwll.local>
Date:   Mon, 14 Aug 2017 16:12:37 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     airlied@...ux.ie, airlied@...hat.com, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: udl: constify usb_device_id

On Sat, Aug 12, 2017 at 02:05:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/udl/udl_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index cd8b017..2877afc 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -118,7 +118,7 @@ static void udl_usb_disconnect(struct usb_interface *interface)
>   * which is compatible with all known USB 2.0 era graphics chips and firmware,
>   * but allows DisplayLink to increment those for any future incompatible chips
>   */
> -static struct usb_device_id id_table[] = {
> +static const struct usb_device_id id_table[] = {
>  	{.idVendor = 0x17e9, .bInterfaceClass = 0xff,
>  	 .bInterfaceSubClass = 0x00,
>  	 .bInterfaceProtocol = 0x00,
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives