linux-kernel - Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 16:51:28 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Michal Simek <michal.simek@...inx.com>
CC:     <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
        <linux-watchdog@...r.kernel.org>, Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module
 parameters

On 14.8.2017 16:47, Guenter Roeck wrote:
> On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote:
>> Give read access to module parameters to all and write access to root.
>> This change also improves driver error path testing.
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
>> ---
>>
>> Please let me know what you think - I can use macros from stat.h if
>> required
>>
> You mean instead of 0644 ? That is discouraged nowadays.

yep and good.

Thanks,
Michal