linux-kernel - Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order calling lstcon_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 15:58:57 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     Colin King <colin.king@...onical.com>
cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Doug Oucharek <doug.s.oucharek@...el.com>,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: lnet: fix incorrect arguments order
 calling lstcon_session_new



> From: Colin Ian King <colin.king@...onical.com>
> 
> The arguments args->lstio_ses_force and args->lstio_ses_timeout are
> in the incorrect order. Fix this by swapping them around.
> 
> Detected by CoverityScan, CID#1226833 ("Arguments in wrong order")

This patch is being tracked under 

https://jira.hpdd.intel.com/browse/LU-9869

I pushed the patch into our main test framework which passed testing.
Just waiting for reviews. Thank you.
 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/staging/lustre/lnet/selftest/conctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging/lustre/lnet/selftest/conctl.c
> index 6ca7192b03b7..043eafb5ea40 100644
> --- a/drivers/staging/lustre/lnet/selftest/conctl.c
> +++ b/drivers/staging/lustre/lnet/selftest/conctl.c
> @@ -69,8 +69,8 @@ lst_session_new_ioctl(struct lstio_session_new_args *args)
>  	rc = lstcon_session_new(name,
>  				args->lstio_ses_key,
>  				args->lstio_ses_feats,
> -				args->lstio_ses_force,
>  				args->lstio_ses_timeout,
> +				args->lstio_ses_force,
>  				args->lstio_ses_idp);
>  
>  	LIBCFS_FREE(name, args->lstio_ses_nmlen + 1);
> -- 
> 2.11.0
> 
>