linux-kernel - Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1297f68-112e-1a93-d769-ad06b04714cd@rock-chips.com>
Date:   Mon, 14 Aug 2017 09:18:36 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Li Wei <liwei213@...wei.com>, ulf.hansson@...aro.org,
        jh80.chung@...sung.com, hkallweit1@...il.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     shawn.lin@...k-chips.com, guodong.xu@...aro.org
Subject: Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver
 init

Trim cc

On 2017/8/11 16:06, Li Wei wrote:
> This commit modifies dw_mci_probe(), it moves reset assertion before
> drv_data->init(host)
> 
> Some driver needs to access controller registers in its .init() ops. So,
> in order to make such access safe, we should do controller reset before
> .init() being called.
> 

LGTM

Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>

> Signed-off-by: Wei Li <liwei213@...wei.com>
> Signed-off-by: Guodong Xu <guodong.xu@...aro.org>
> Signed-off-by: Chen Jun <chenjun14@...wei.com>
> ---