linux-kernel - Re: [PATCH v2] platform/x86: ideapad-laptop: Expose conservation mode switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7e7481b-a96d-2ac4-145b-f2128252591c@in04.sg>
Date:   Mon, 14 Aug 2017 23:51:24 +0800
From:   Hao Wei Tee <angelsl@...4.sg>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Ike Panhc <ike.pan@...onical.com>
Subject: Re: [PATCH v2] platform/x86: ideapad-laptop: Expose conservation mode
 switch

On 14/8/2017 23:32, Andy Shevchenko wrote:
> On Mon, Aug 14, 2017 at 5:17 PM, Hao Wei Tee <angelsl@...4.sg> wrote:
>> This exposes the battery conservation mode present on some (?) IdeaPads.
>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>> GBMD.
> 
> Thanks for an update, this looks pretty much good!
> 
> Still some kind of nitpicks below.
> 
>> +#define GBMD_CONSERVATION_BIT (5)
> 
>> +enum {
>> +       SBMC_CONSERVATION_ON = 3,
>> +       SBMC_CONSERVATION_OFF = 5,
> 
> Looks to me like
> GBMD = Get BM Data
> SBMC = Send BM Command
> 
> Thus, I would leave BM only in the above (do you know by the way what
> BM stands for?

Now that you mention it, it might stand for battery management.

-- 
Hao Wei