[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170814193423.er7hpbxpddztltwp@ninjato>
Date: Mon, 14 Aug 2017 21:34:23 +0200
From: Wolfram Sang <wsa@...-dreams.de>
To: Javier Martinez Canillas <javierm@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: core: Make comment about I2C table requirement to
reflect the code
On Wed, Aug 09, 2017 at 11:21:28AM +0200, Javier Martinez Canillas wrote:
> I2C drivers were required to have an I2C device ID table even if were for
> devices that would only be registered using a specific firmware interface
> (e.g: OF or ACPI).
>
> But commit da10c06a044b ("i2c: Make I2C ID tables non-mandatory for DT'ed
> devices") changed the I2C core to relax the requirement and allow drivers
> to avoid defining this table.
>
> Unfortunately it only took into account drivers for OF-only devices and
> forgot about ACPI-only ones, and this was fixed by commit c64ffff7a9d1
> ("i2c: core: Allow empty id_table in ACPI case as well").
>
> But the latter didn't update the original comment, so it doesn't reflect
> what the code does now.
>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
Applied to for-current, thanks!
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists