linux-kernel - Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170814194713.c6ojqcbi2iluayau@ninjato>
Date:   Mon, 14 Aug 2017 21:47:13 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Jun Gao <jun.gao@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        srv_heupstream@...iatek.com, devicetree@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek
 MT7622

On Mon, Aug 14, 2017 at 09:36:56AM +0800, Jun Gao wrote:
> On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > > +	.max_num_msgs = 255,
> > > +	.max_write_len = 65535,
> > > +	.max_read_len = 65535,
> > > +	.max_comb_1st_msg_len = 65535,
> > > +	.max_comb_2nd_msg_len = 65535,
> > > +};
> > 
> > That looks like no quirks? Then just leave the quirks pointer below
> > empty.
> > 
> Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.

I see. But you can safely drop all the length settings. The i2c core has
this comment in quirk handling:

/* Check if val is exceeding the quirk IFF quirk is non 0 */

IFF means "if and only if".


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)