Message-ID: <20170814202854.GC2641@redhat.com>
Date:   Mon, 14 Aug 2017 17:28:54 -0300
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Michael Petlan <mpetlan@...hat.com>
Cc:     tmricht@...ux.vnet.ibm.com, namhyung@...nel.org, dsahern@...il.com,
        Jiri Olsa <jolsa@...hat.com>, tglx@...utronix.de,
        hpa@...or.com, mingo@...nel.org, adrian.hunter@...el.com,
        wangnan0@...wei.com, linux-kernel@...r.kernel.org, acme@...nel.org
Subject: Re: [tip:perf/core] perf test shell: Install shell tests

Em Mon, Aug 14, 2017 at 08:44:14PM +0200, Michael Petlan escreveu:
> Hi Arnaldo!
> 
> Maybe this would be the right time to incorporate the shell-based
> perftool-testsuite [1] into perf-test, wouldn't it?

Perhaps its time, yes. Some questions:

Do these tests assume that perf was built in some particular way, i.e.
as it is packaged for RHEL?

One thing that came to mind from a report from Kim Phillips, that I
addressed (to some extent) after this sending this first patchkit to
Ingo was that perf can be built in many ways, for instance, without
'perf probe', or with 'perf probe' but without DWARF support, which will
allow some features to be tested while others should cause the test
needing not-builtin features to just return '2', that will make it be
marked as "Skip" in the output.

- Arnaldo
 
> It already contains bunch of shell-based perf tests that cover
> 25+ RH bugs...
> 
> A little problem might be different design, since the testsuite
> has multiple levels of hierarchy of sub-sub-sub-tests, like:
> 
> ...
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: custom named probe :: add
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: custom named probe :: list
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: custom named probe :: use
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: various syntax forms :: vfs_read@...read_write.c
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: various syntax forms :: vfs_read:11@...read_write.c
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: various syntax forms :: vfs_read@...read_write.c:11
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: various syntax forms :: vfs_read%return
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: various syntax forms :: test.c:29
> -- [ PASS ] -- perf_probe :: test_probe_syntax :: various syntax forms :: func%return $retval
> ## [ PASS ] ## perf_probe :: test_probe_syntax SUMMARY
> -- [ PASS ] -- perf_probe :: test_sdt :: adding SDT tracepoints as probes
> -- [ PASS ] -- perf_probe :: test_sdt :: listing added probes
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf stat (N = 13)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf stat (N = 128)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf stat (N = 241)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf record (N = 37)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf report (N = 37)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf script (N = 37)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf record (N = 97)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf report (N = 97)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf script (N = 97)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf record (N = 237)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf report (N = 237)
> -- [ PASS ] -- perf_probe :: test_sdt :: using probes :: perf script (N = 237)
> ## [ PASS ] ## perf_probe :: test_sdt SUMMARY
> ...
> 
> ... which does not exactly match how perf-test is structured, however,
> I think that the multi-level structure of the testsuite is important
> for keeping some order in it...
> 
> What do you think?
> 
> Cheers,
> Michael
> 
> 
> 
> [1] https://github.com/rfmvh/perftool-testsuite
> 
> 
> On Mon, 14 Aug 2017, tip-bot for Arnaldo Carvalho de Melo wrote:
> 
> > Commit-ID:  122e0b947052f6106595fa29d63d514d2ebcdad9
> > Gitweb:     http://git.kernel.org/tip/122e0b947052f6106595fa29d63d514d2ebcdad9
> > Author:     Arnaldo Carvalho de Melo <acme@...hat.com>
> > AuthorDate: Fri, 4 Aug 2017 12:19:44 -0300
> > Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
> > CommitDate: Fri, 11 Aug 2017 16:06:28 -0300
> > 
> > perf test shell: Install shell tests
> > 
> > Now that we have shell tests, install them.
> > 
> > Developers don't need this pass, as 'perf test' will look first at the
> > in tree scripts at tools/perf/tests/shell/.
> > 
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: David Ahern <dsahern@...il.com>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Michael Petlan <mpetlan@...hat.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Thomas Richter <tmricht@...ux.vnet.ibm.com>
> > Cc: Wang Nan <wangnan0@...wei.com>
> > Link: http://lkml.kernel.org/n/tip-j21u4v0jsehi0lpwqwjb4j45@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > ---
> >  tools/perf/Makefile.perf | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index c1f7884..eb13567 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -760,7 +760,9 @@ install-tests: all install-gtk
> >  		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> >  		$(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \
> >  		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
> > -		$(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'
> > +		$(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \
> > +		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell'; \
> > +		$(INSTALL) tests/shell/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell'
> >  
> >  install-bin: install-tools install-tests install-traceevent-plugins
> >  
> > 

Powered by blists - more mailing lists