linux-kernel - Re: [PATCH] selftests: timers: freq-step: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLXHX_W68ufGJOWv5ECBQFFG=451EMfKQN0L4eL9eUmCCw@mail.gmail.com>
Date:   Mon, 14 Aug 2017 13:59:23 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...eaurora.org>,
        lkml <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: timers: freq-step: fix compile error

On Mon, Aug 14, 2017 at 1:17 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
> On 08/14/2017 02:12 PM, John Stultz wrote:
>> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
>>> Fix compile error due to ksft_exit_skip() update to take var_args.
>>>
>>> freq-step.c: In function ‘init_test’:
>>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>>>    ksft_exit_skip();
>>>    ^~~~~~~~~~~~~~
>>> In file included from freq-step.c:26:0:
>>> ../kselftest.h:167:19: note: declared here
>>>  static inline int ksft_exit_skip(const char *msg, ...)
>>>                    ^~~~~~~~~~~~~~
>>> <builtin>: recipe for target 'freq-step' failed
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>>
>>
>> Acked-by: John Stultz <john.stultz@...aro.org>
>>
>> This is a build regression in 4.13-rc so should go-to Linus promptly.
>>
>> (Shuah: Let me know if you want me to send this in via Thomas, or you
>> want to send it in directly)
>>
>> thanks
>> -john
>>
>
> John,
>
> I am planning to send it to Linus with a few other fixes in linux-kselftest
> fixes branch for 4.13-rc6

I also have two more less critical build fixups to that test to add,
which I'll send out here in a second for review.

thanks
-john