linux-kernel - Re: [2/2] watchdog: of_xilinx_wdt: Add suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170815015155.GA32016@roeck-us.net>
Date:   Mon, 14 Aug 2017 18:51:55 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [2/2] watchdog: of_xilinx_wdt: Add suspend/resume support

On Mon, Aug 07, 2017 at 01:24:23PM +0200, Michal Simek wrote:
> Add suspend/resume support to driver.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> 
>  drivers/watchdog/of_xilinx_wdt.c | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 41edeb93a327..1cf286945b7a 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -264,6 +264,43 @@ static int xwdt_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +/**
> + * xwdt_suspend - Suspend the device.
> + *
> + * @dev: handle to the device structure.
> + * Return: 0 always.
> + */
> +static int __maybe_unused xwdt_suspend(struct device *dev)
> +{
> +	struct platform_device *pdev = to_platform_device(dev);
> +	struct xwdt_device *xdev = platform_get_drvdata(pdev);
> +
> +	if (watchdog_active(&xdev->xilinx_wdt_wdd))
> +		xilinx_wdt_stop(&xdev->xilinx_wdt_wdd);
> +
> +	return 0;
> +}
> +
> +/**
> + * xwdt_resume - Resume the device.
> + *
> + * @dev: handle to the device structure.
> + * Return: 0 on success, errno otherwise.
> + */
> +static int __maybe_unused xwdt_resume(struct device *dev)
> +{
> +	struct platform_device *pdev = to_platform_device(dev);
> +	struct xwdt_device *xdev = platform_get_drvdata(pdev);
> +	int ret = 0;
> +
> +	if (watchdog_active(&xdev->xilinx_wdt_wdd))
> +		ret = xilinx_wdt_start(&xdev->xilinx_wdt_wdd);
> +
> +	return ret;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(xwdt_pm_ops, xwdt_suspend, xwdt_resume);
> +
>  /* Match table for of_platform binding */
>  static const struct of_device_id xwdt_of_match[] = {
>  	{ .compatible = "xlnx,xps-timebase-wdt-1.00.a", },
> @@ -278,6 +315,7 @@ static int xwdt_remove(struct platform_device *pdev)
>  	.driver = {
>  		.name  = WATCHDOG_NAME,
>  		.of_match_table = xwdt_of_match,
> +		.pm = &xwdt_pm_ops,
>  	},
>  };
>