linux-kernel - Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2017 17:57:10 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Frederico Cadete <frederico@...ete.eu>
Cc:     linux-kernel@...r.kernel.org, linux@...f-Entwicklungen.de
Subject: Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask

On Sun, Aug 13, 2017 at 09:43:50PM +0200, Frederico Cadete wrote:
> The code was using the logical negation operator "!", effectively never
> triggering the error path. To check the bitmask we should use the
> bitwise negation "~".
> 
> Cleans up sparse warning:
>   warning: dubious: x & !y
> 
> Signed-off-by: Frederico Cadete <frederico@...ete.eu>
> ---
>  drivers/staging/pi433/rf69.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(