linux-kernel - Re: [PATCH] f2fs-tools: the overprovision should be 0 as default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170815032425.GB91145@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 14 Aug 2017 20:24:25 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Yunlong Song <yunlong.song@...wei.com>
Cc:     chao@...nel.org, yuchao0@...wei.com, yunlong.song@...oud.com,
        miaoxie@...wei.com, bintian.wang@...wei.com,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs-tools: the overprovision should be 0 as default

On 08/11, Yunlong Song wrote:
> The usage message gives a wrong number, so fix it.
> 
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
> ---
>  mkfs/f2fs_format_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index a3652a9..6712b5c 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -41,7 +41,7 @@ static void mkfs_usage()
>  	MSG(0, "  -f force overwrite the exist filesystem\n");
>  	MSG(0, "  -l label\n");
>  	MSG(0, "  -m support zoned block device [default:0]\n");
> -	MSG(0, "  -o overprovision ratio [default:5]\n");
> +	MSG(0, "  -o overprovision ratio [default:0]\n");

We need to remove [default:xx], since the default is not fixed?

>  	MSG(0, "  -O [feature list] e.g. \"encrypt\"\n");
>  	MSG(0, "  -q quiet mode\n");
>  	MSG(0, "  -s # of segments per section [default:1]\n");
> -- 
> 1.8.5.2