linux-kernel - Re: [PATCH v5 0/6] drivers/i2c: Add FSI-attached I2C master algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Aug 2017 08:36:59 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Eddie James <eajames@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        wsa@...-dreams.de, robh+dt@...nel.org, jk@...abs.org,
        joel@....id.au, andrew@...id.au, cbostic@...ux.vnet.ibm.com,
        "Edward A. James" <eajames@...ibm.com>
Subject: Re: [PATCH v5 0/6] drivers/i2c: Add FSI-attached I2C master algorithm

On 2017-07-26 19:13, Eddie James wrote:
> From: "Edward A. James" <eajames@...ibm.com>
> 
> This series adds an algorithm for an I2C master physically located on an FSI
> slave device. The I2C master has multiple ports, each of which may be connected
> to an I2C slave. Access to the I2C master registers is achieved over FSI bus.
> 
> Due to the multi-port nature of the I2C master, the driver instantiates a new
> I2C adapter for each port connected to a slave. The connected ports should be
> defined in the device tree under the I2C master device.

Hmmm, AFAIU fsi is a bus, and on this bus you have some "client" device that
happens to be an i2c master, and this is a driver for that "client". Is it
totally inconceivable to have some other client device in the future that is
implementing an i2c master differently, but still using the fsi bus?

With that in mind, is it wise to pick the driver name from the bus that the
device is connected to, and nothing else without further qualification?

I don't see any "i2c-usb" driver, but I think there are a couple of i2c master
drivers that communicate via usb.

Cheers,
Peter