linux-kernel - Re: [PATCH] platform/chrome: cros_ec_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170815064712.GB100591@decatoncale.mtv.corp.google.com>
Date:   Mon, 14 Aug 2017 23:47:12 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     bleung@...omium.org, Olof Johansson <olof@...om.net>,
        linux-kernel@...r.kernel.org, bleung@...gle.com
Subject: Re: [PATCH] platform/chrome: cros_ec_dev - Use devm_mfd_add_devices

Hi Jeffy,

On Mon, Aug 07, 2017 at 07:18:54PM +0800, Jeffy Chen wrote:
> Currently we are calling mfd_add_devices to add devices without matched
> mfd_remove_devices to remove them.
> 
> That would cause warning when re-binding cros_ec_dev:
> 
> [  123.536192] sysfs: cannot create duplicate filename '/bus/platform/devices/cros-
> ec-accel.0'
> [  123.536210] ------------[ cut here ]------------
> [  123.536223] WARNING: CPU: 3 PID: 156 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x
> 84
> [  123.536226] Modules linked in:
> [  123.536236] CPU: 3 PID: 156 Comm: bash Not tainted 4.13.0-rc3-next-20170731 #216
> [  123.536238] Hardware name: Google Kevin (DT)
> [  123.536242] task: ffffffc0f28bab80 task.stack: ffffffc0f1b30000
> [  123.536247] PC is at sysfs_warn_dup+0x68/0x84
> [  123.536251] LR is at sysfs_warn_dup+0x68/0x84
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>

Thanks for the fix. Applied for v4.14.

Thanks,
Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)