linux-kernel - Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfa3213f-8322-ca9c-8170-122f268f3ce3@intel.com>
Date:   Tue, 15 Aug 2017 09:46:38 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Piotr Sroka <piotrs@...ence.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support

On 14/08/17 18:28, Masahiro Yamada wrote:
> Hi Adrian,
> 
> 
> 2017-08-14 19:53 GMT+09:00 Adrian Hunter <adrian.hunter@...el.com>:
> 
>>> @@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>>>       return ret;
>>>  }
>>>
>>> +static int __maybe_unused sdhci_cdns_resume(struct device *dev)
>>
>> We don't use __maybe_unused in this case, we use #ifdef CONFIG_PM_SLEEP
> 
> 
> Could you tell me the reason
> why #ifdef CONFIG_PM_SLEEP is preferable?
> 
> I see lots of __maybe_unused for suspend/resume hooks in drivers.

Not in sdhci drivers.  It is easier for the maintainer to have consistency
across the code they maintain.